Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace polkadot extension signer with tfchain wallet connector signer in portal #823

Merged
merged 20 commits into from
Jul 25, 2023

Conversation

MohamedElmdary
Copy link
Member

@MohamedElmdary MohamedElmdary commented Jul 18, 2023

@AhmedHanafy725
Copy link
Contributor

first testing round:

  • before the login page looks so bad
    image

  • after the first login, it didn't move to the account page
    image

  • after logout, the balance is still there, the navbar is corrupted, and still can see the info of the previously logged-in user
    image

  • set extra fee is not working, still depending on the extension
    image

@0oM4R
Copy link
Contributor

0oM4R commented Jul 19, 2023

same issues Hanafy mentioned above;

Screencast.from.19.2023.EEST.11.50.44.webm

generate account btn not working

Screencast.from.19.2023.EEST.11.59.45.webm

suggestions:

1- remove shh field there is no need for it here
2- add btn to show the password and the Mnem before login

@0oM4R
Copy link
Contributor

0oM4R commented Jul 19, 2023

testing portal

  • twin ✔️
    • generate account ✔️

      • maybe if we add show and copy icons will be better
      • login to portal for first time ✔️
      • logout ✔️
        image
    • I think there is no need to show the balance again we can just show the account name only

  • Bridge ✔️
    • withdraw ✔️
    • deposit ✔️
  • transfer ✔️
  • Farm ✔️
    • "set extra fee is not working, still depending on the extension" ✔️
      image

    • Creating a new farm works fine ✔️

    • add public ip for the created farm ✔️

  • Dedicated Nodes ✔️
    • Rent node tested
  • DAO ✔️
    • vote and notification pop up works fine

@0oM4R
Copy link
Contributor

0oM4R commented Jul 20, 2023

testing portal

  • twin heavy_check_mark

    • generate account heavy_check_mark

      • maybe if we add show and copy icons will be better
      • login to portal for first time heavy_check_mark
      • logout heavy_check_mark
        image
    • I think there is no need to show the balance again we can just show the account name only

  • Bridge heavy_check_mark

    • withdraw heavy_check_mark
    • deposit heavy_check_mark
  • transfer heavy_check_mark

  • Farm heavy_check_mark

    • "set extra fee is not working, still depending on the extension" heavy_check_mark
      image
    • Creating a new farm works fine heavy_check_mark
    • add public ip for the created farm heavy_check_mark
  • Dedicated Nodes heavy_check_mark

    • Rent node tested
  • DAO heavy_check_mark

    • vote and notification pop up works fine

all mentioned issues are resolved;

@AhmedHanafy725 AhmedHanafy725 merged commit 737214d into development Jul 25, 2023
@AhmedHanafy725 AhmedHanafy725 deleted the development_tfchain_connector_dashboard_2 branch July 25, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants