-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace polkadot extension signer with tfchain wallet connector signer in portal #823
Merged
AhmedHanafy725
merged 20 commits into
development
from
development_tfchain_connector_dashboard_2
Jul 25, 2023
Merged
Replace polkadot extension signer with tfchain wallet connector signer in portal #823
AhmedHanafy725
merged 20 commits into
development
from
development_tfchain_connector_dashboard_2
Jul 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamedElmdary
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
Mahmoud-Emad,
amiraabouhadid and
Omarabdul3ziz
as code owners
July 18, 2023 13:01
first testing round: |
same issues Hanafy mentioned above;Screencast.from.19.2023.EEST.11.50.44.webmgenerate account btn not workingScreencast.from.19.2023.EEST.11.59.45.webmsuggestions:1- remove shh field there is no need for it here |
testing portal
|
all mentioned issues are resolved; |
0oM4R
approved these changes
Jul 25, 2023
AhmedHanafy725
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues